LGTM with comments if it lints.
http://codereview.chromium.org/149069/diff/3003/2006 File src/parser.cc (right): http://codereview.chromium.org/149069/diff/3003/2006#newcode608 Line 608: struct RegExpParserState : public ZoneObject { Please make this a real object. http://codereview.chromium.org/149069/diff/3003/2006#newcode3863 Line 3863: RegExpParserState* stored_state = NULL; If you initialize this to an initial stored state instead then you can have the group_type live inside the stored state. Also the disjunction_capture_index. http://codereview.chromium.org/149069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
