LGTM with a few comments.
http://codereview.chromium.org/126109/diff/1/2 File src/messages.js (right): http://codereview.chromium.org/126109/diff/1/2#newcode165 Line 165: // arbitrary limit, grab a reasonable slice to report Please start comment with uppercase and end with a dot. http://codereview.chromium.org/126109/diff/1/2#newcode374 Line 374: var from_line = IS_UNDEFINED(opt_from_line) Please write like this: var from_line = IS_UNDEFINED(opt_from_line) ? this.line_offset : opt_from_line; http://codereview.chromium.org/126109/diff/1/2#newcode376 Line 376: var to_line = IS_UNDEFINED(opt_to_line) See above. http://codereview.chromium.org/126109 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
