Reviewers: Mads Ager, Description: Reverted change to ASSERT is void Dictionary<Shape, Key>::SetEntry.
Please review this at http://codereview.chromium.org/150212 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects-inl.h Index: src/objects-inl.h =================================================================== --- src/objects-inl.h (revision 2331) +++ src/objects-inl.h (working copy) @@ -2642,7 +2642,7 @@ Object* key, Object* value, PropertyDetails details) { - ASSERT(!Shape::kIsEnumerable || details.index() > 0); + ASSERT(!key->IsString() || details.index() > 0); int index = HashTable<Shape, Key>::EntryToIndex(entry); WriteBarrierMode mode = FixedArray::GetWriteBarrierMode(); FixedArray::set(index, key, mode); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
