If you make sure it compiles on non-IA32 platforms, it LGTM...
http://codereview.chromium.org/150225/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/150225/diff/1/2#newcode52 Line 52: // Get the code entry from the cache. I take it you've considered having multiple extra.is_valid checks in this function but decided that made the code too unreadable? It's probably the right decision... http://codereview.chromium.org/150225/diff/1/4 File src/stub-cache.h (right): http://codereview.chromium.org/150225/diff/1/4#newcode199 Line 199: // Generate code for probing the stub cache table. I think you should add a note about the contract here. Both scratch and extra will be clobbered, but it's okay to pass in no_reg for extra... or something like that. http://codereview.chromium.org/150225/diff/1/4#newcode205 Line 205: Register extra); Will this change break the compilation of all non-IA32 platforms? http://codereview.chromium.org/150225 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
