http://codereview.chromium.org/155083/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/155083/diff/1/4#newcode4396
Line 4396: __ cmpl(answer.reg(), Immediate(0));
On 2009/07/06 13:00:17, Lasse Reichstein wrote:
> Is this different from testl?

Done.

http://codereview.chromium.org/155083/diff/1/4#newcode5630
Line 5630: __ movq(kScratchRegister, rax);
On 2009/07/06 13:00:17, Lasse Reichstein wrote:
> How about movcc(not_equal, rax, Immediate(1))
> or even setcc(not_equal, rax)?

We don't have conditional moves yet.  I'll leave it as a TODO

http://codereview.chromium.org/155083

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to