LGTM with comments. -Ivan
http://codereview.chromium.org/149304/diff/1/2 File src/factory.cc (right): http://codereview.chromium.org/149304/diff/1/2#newcode573 Line 573: DescriptorWriter w(*result); Please put a scope around this with a comment that a DescriptorWriter can be safely used here because copying entries does not cause a GC. http://codereview.chromium.org/149304/diff/1/2#newcode597 Line 597: // Do not use the DescriptorWriter 'w' here. SymbolFromString At which point you can skip the reference to w in this comment and instead just say that SymbolFromString can cause allocation which is why we need to use handle based accesses to the result array. http://codereview.chromium.org/149304 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
