Reviewers: Erik Corry, Description: X64: Turn of gcc strict-aliasing optimization for X64 release.
Please review this at http://codereview.chromium.org/155208 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct M src/compilation-cache.cc Index: src/compilation-cache.cc =================================================================== --- src/compilation-cache.cc (revision 2386) +++ src/compilation-cache.cc (working copy) @@ -164,7 +164,7 @@ tables_[generation] = *result; } else { CompilationCacheTable* table = - CompilationCacheTable::cast(tables_[generation]); + bit_cast<CompilationCacheTable*, Object*>(tables_[generation]); result = Handle<CompilationCacheTable>(table); } return result; @@ -281,6 +281,7 @@ HandleScope scope; ASSERT(boilerplate->IsBoilerplate()); Handle<CompilationCacheTable> table = GetTable(0); + // TODO(X64): -fstrict-aliasing causes a problem with table. Fix it. CALL_HEAP_FUNCTION_VOID(table->Put(*source, *boilerplate)); } Index: SConstruct =================================================================== --- SConstruct (revision 2386) +++ SConstruct (working copy) @@ -172,6 +172,7 @@ 'CPPDEFINES': ['V8_TARGET_ARCH_ARM'] }, 'arch:x64': { + 'CCFLAGS': ['-fno-strict-aliasing'], 'CPPDEFINES': ['V8_TARGET_ARCH_X64'] }, 'prof:oprofile': { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
