Author: [email protected]
Date: Wed Jul 8 15:05:06 2009
New Revision: 2400
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
Log:
Fix crash bug in ARM codegenerator by adding another special case for
generating code after a call to LoadConditionAndSpill.
This crash is hit on www.rightmove.co.uk when using the ARM
codegenerator.
Review URL: http://codereview.chromium.org/149351
Modified: branches/bleeding_edge/src/arm/codegen-arm.cc
==============================================================================
--- branches/bleeding_edge/src/arm/codegen-arm.cc (original)
+++ branches/bleeding_edge/src/arm/codegen-arm.cc Wed Jul 8 15:05:06 2009
@@ -3615,7 +3615,10 @@
false_target(),
true_target(),
true);
- cc_reg_ = NegateCondition(cc_reg_);
+ // LoadConditionAndSpill might emit only unconditional jumps to
+ // the targets in which case cc_reg_ is not set. When that
+ // happens, don't attempt to negate the condition.
+ if (has_cc()) cc_reg_ = NegateCondition(cc_reg_);
} else if (op == Token::DELETE) {
Property* property = node->expression()->AsProperty();
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
