LGTM. Only formatting comments.
http://codereview.chromium.org/155279/diff/1/5 File test/mjsunit/apply.js (left): http://codereview.chromium.org/155279/diff/1/5#oldcode59 Line 59: assertEquals("foo", f1.apply(this, new Array("foo", "bar", "baz", "boo")), "2c"); Why not just shorten "bar", "baz" and "boo" by a character or two? http://codereview.chromium.org/155279/diff/1/5 File test/mjsunit/apply.js (right): http://codereview.chromium.org/155279/diff/1/5#newcode196 Line 196: "morseper", I think you can put the first argument on the same line, but indent 2nd and third argument only 4 spaces. http://codereview.chromium.org/155279 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
