Author: [email protected]
Date: Fri Jul 10 01:36:37 2009
New Revision: 2424
Modified:
branches/bleeding_edge/src/d8-posix.cc
Log:
Fixed issue 401: os.system() hangs on Mac OS X.
Fixed by falling back to using 'waitpid' instead of 'waitid'.
BUG=http://code.google.com/p/v8/issues/detail?id=401
Review URL: http://codereview.chromium.org/149450
Modified: branches/bleeding_edge/src/d8-posix.cc
==============================================================================
--- branches/bleeding_edge/src/d8-posix.cc (original)
+++ branches/bleeding_edge/src/d8-posix.cc Fri Jul 10 01:36:37 2009
@@ -370,7 +370,11 @@
// whether it exited normally. In the common case this doesn't matter
because
// we don't get here before the child has closed stdout and most programs
don't
// do that before they exit.
-#if defined(WNOWAIT) && !defined(ANDROID)
+//
+// We're disabling usage of waitid in Mac OS X because it doens't work for
us:
+// a parent process hangs on waiting while a child process is already a
zombie.
+// See http://code.google.com/p/v8/issues/detail?id=401.
+#if defined(WNOWAIT) && !defined(ANDROID) && !defined(__APPLE__)
#define HAS_WAITID 1
#endif
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---