http://codereview.chromium.org/149458/diff/1/11 File src/factory.cc (right):
http://codereview.chromium.org/149458/diff/1/11#newcode575 Line 575: result->SetFrom(descriptor_count++, *array, i); On 2009/07/10 16:36:15, iposva wrote: > This would probably be more readable if SetFrom was renamed to CopyFrom, which > to me indicates that you are copying an entry from one descriptor array to the > target index. I agree. Thanks. http://codereview.chromium.org/149458/diff/1/11#newcode595 Line 595: // We do not use a DescriptorWriter because SymbolFromString can On 2009/07/10 16:36:15, iposva wrote: > The DescriptorWriter comment is now outdated here. Whoops, done. http://codereview.chromium.org/149458 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
