LGTM. I plan on adding a regression test case or two for this issue today. I'll make sure it passes on ARM too.
On Tue, Jul 14, 2009 at 12:54 AM, <[email protected]> wrote: > Reviewers: Feng Qian, > > Description: > Put the work-around for http://crbug.com/16276 into the ARM port as > well. > > > Please review this at http://codereview.chromium.org/155459 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/ic-arm.cc > > > Index: src/arm/ic-arm.cc > =================================================================== > --- src/arm/ic-arm.cc (revision 2449) > +++ src/arm/ic-arm.cc (working copy) > @@ -77,6 +77,12 @@ > __ cmp(r3, Operand(JS_GLOBAL_PROXY_TYPE)); > __ b(eq, miss); > > + // Possible work-around for http://crbug.com/16276. > + __ cmp(r3, Operand(JS_GLOBAL_OBJECT_TYPE)); > + __ b(eq, miss); > + __ cmp(r3, Operand(JS_BUILTINS_OBJECT_TYPE)); > + __ b(eq, miss); > + > // Check that the properties array is a dictionary. > __ ldr(t0, FieldMemOperand(t1, JSObject::kPropertiesOffset)); > __ ldr(r3, FieldMemOperand(t0, HeapObject::kMapOffset)); > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
