LGTM.
http://codereview.chromium.org/149530/diff/1/2 File benchmarks/v1/run.html (right): http://codereview.chromium.org/149530/diff/1/2#newcode67 Line 67: background:#ffffd9; Space after :. http://codereview.chromium.org/149530/diff/1/2#newcode106 Line 106: function showWarning() { showWarning -> ShowWarning. It's still a weird name, because it only shows the warning if it's obsolete. Maybe change the name to reflect this? ShowWarningIfObsolete? http://codereview.chromium.org/149530/diff/1/2#newcode108 Line 108: var latesturl = "../v" + (parseInt(BenchmarkSuite.version)+1) + "/run.html"; Spaces around +. http://codereview.chromium.org/149530/diff/1/2#newcode108 Line 108: var latesturl = "../v" + (parseInt(BenchmarkSuite.version)+1) + "/run.html"; Weird name. Why not latest_url? http://codereview.chromium.org/149530/diff/1/2#newcode111 Line 111: } else { else if (...) instead of else { if (...) http://codereview.chromium.org/149530/diff/1/2#newcode117 Line 117: xmlhttp.open('GET', latesturl, true); It's a bit weird that you even try this if xmlhttp is null. http://codereview.chromium.org/149530/diff/1/2#newcode119 Line 119: if (xmlhttp.readyState==4 && xmlhttp.status==200) { Spaces around ==. http://codereview.chromium.org/149530/diff/1/2#newcode125 Line 125: // Ignore exception if check for newer version fails Terminate comment with . http://codereview.chromium.org/149530/diff/1/2#newcode141 Line 141: Warning! This is not the latest version of V8 Benchmark Suite. For the latest version please visit <a href="http://v8.googlecode.com/svn/data/benchmarks/current/run.html";>this page</a>. Maybe wrap the line a bit differently? 80 characters per line. How about changing the wording to something like: Warning! This is not the latest version of the V8 benchmark suite. Consider running the <a>latest version</a>. http://codereview.chromium.org/149530 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
