Thanks, Kasper!
http://codereview.chromium.org/149513/diff/1/10 File tools/tickprocessor.js (right): http://codereview.chromium.org/149513/diff/1/10#newcode387 Line 387: if (prevEntry && !('end' in prevEntry) && On 2009/07/14 07:52:57, Kasper Lund wrote: > The 'end' in prevEntry stuff looks a bit weird to me. I think it would be more > common just to use prevEntry.end, unless you worry about it being zero. You're right, zero is a forbidden value here. Changed to value check. http://codereview.chromium.org/149513/diff/1/10#newcode410 Line 410: if ('size' in funcInfo) { On 2009/07/14 07:52:57, Kasper Lund wrote: > Is this because you worry that size can be zero? Done. http://codereview.chromium.org/149513 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
