Reviewers: Søren Gjesse, Message: Updated per comments. Please double-check link 890. That's the way a "return" is split in variables.h:181 ...
- Matt On 2009/07/01 16:55:05, Søren Gjesse wrote: > LGTM with a few comments. > http://codereview.chromium.org/126109/diff/1/2 > File src/messages.js (right): > http://codereview.chromium.org/126109/diff/1/2#newcode165 > Line 165: // arbitrary limit, grab a reasonable slice to report > Please start comment with uppercase and end with a dot. > http://codereview.chromium.org/126109/diff/1/2#newcode374 > Line 374: var from_line = IS_UNDEFINED(opt_from_line) > Please write like this: > var from_line = > IS_UNDEFINED(opt_from_line) ? this.line_offset : opt_from_line; > http://codereview.chromium.org/126109/diff/1/2#newcode376 > Line 376: var to_line = IS_UNDEFINED(opt_to_line) > See above. Description: Fix all lines > 80 chars in messages.js so they are <= 80. I tried to follow precedence in the existing code base, but am unsure if my way of splitting long string constants is acceptable Updated 7/15 per review comments Please review this at http://codereview.chromium.org/126109 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/messages.js --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
