Reviewers: Kasper Lund, Description: Fix issue 345 by avoiding duplicates in the list of escaping labels from a try...catch...finally statement.
Please review this at http://codereview.chromium.org/149670 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/parser.cc A test/mjsunit/regress/regress-345.js Index: test/mjsunit/regress/regress-345.js =================================================================== --- test/mjsunit/regress/regress-345.js (revision 0) +++ test/mjsunit/regress/regress-345.js (revision 0) @@ -0,0 +1,51 @@ +// Copyright 2009 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Escaping to the same target from both the try and catch blocks of +// try...catch...finally should not fail at compile-time. +// +// Reported by nth10sd. +// See http://code.google.com/p/v8/issues/detail?id=345 + +do { + try { + continue; + } catch (e) { + continue; + } finally { + } +} while (false); + + +L: { + try { + break L; + } catch (e) { + break L; + } finally { + } +} Index: src/parser.cc =================================================================== --- src/parser.cc (revision 2461) +++ src/parser.cc (working copy) @@ -2367,7 +2367,7 @@ result = NEW(TryFinally(try_block, finally_block)); // Add the jump targets of the try block and the catch block. for (int i = 0; i < collector.targets()->length(); i++) { - catch_collector.targets()->Add(collector.targets()->at(i)); + catch_collector.AddTarget(collector.targets()->at(i)); } result->set_escaping_targets(catch_collector.targets()); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
