LGTM.

On Wed, Jul 15, 2009 at 2:06 PM, <[email protected]> wrote:

> Reviewers: Kevin Millikin,
>
> Description:
> Merge r2466 to branches/1.2.
>
> Please review this at http://codereview.chromium.org/155565
>
> SVN Base: http://v8.googlecode.com/svn/branches/1.2/
>
> Affected files:
>  M     src/parser.cc
>  M     src/version.cc
>  A  +  test/mjsunit/regress/regress-345.js
>
>
>
> Index: test/mjsunit/regress/regress-345.js
> Index: src/parser.cc
> ===================================================================
> --- src/parser.cc       (revision 2475)
> +++ src/parser.cc       (working copy)
> @@ -2367,7 +2367,7 @@
>       result = NEW(TryFinally(try_block, finally_block));
>       // Add the jump targets of the try block and the catch block.
>       for (int i = 0; i < collector.targets()->length(); i++) {
> -        catch_collector.targets()->Add(collector.targets()->at(i));
> +        catch_collector.AddTarget(collector.targets()->at(i));
>       }
>       result->set_escaping_targets(catch_collector.targets());
>     }
> Index: src/version.cc
> ===================================================================
> --- src/version.cc      (revision 2475)
> +++ src/version.cc      (working copy)
> @@ -35,7 +35,7 @@
>  #define MAJOR_VERSION     1
>  #define MINOR_VERSION     2
>  #define BUILD_NUMBER      14
> -#define PATCH_LEVEL       1
> +#define PATCH_LEVEL       2
>  #define CANDIDATE_VERSION false
>
>  // Define SONAME to have the SCons build the put a specific SONAME into
> the
>
>
>

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to