Reviewers: Kasper Lund, Message: A tiny review for you.
Description: X64: Enable inline caching for calls, with some stubs stubbed out. Please review this at http://codereview.chromium.org/149674 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ic.cc M src/x64/stub-cache-x64.cc Index: src/ic.cc =================================================================== --- src/ic.cc (revision 2477) +++ src/ic.cc (working copy) @@ -365,13 +365,10 @@ return TypeError("undefined_method", object, name); } - // TODO(X64): Enable inline cache for calls. -#ifndef V8_TARGET_ARCH_X64 // Lookup is valid: Update inline cache and stub cache. if (FLAG_use_ic && lookup.IsLoaded()) { UpdateCaches(&lookup, state, object, name); } -#endif // Get the property. PropertyAttributes attr; @@ -1251,12 +1248,12 @@ Generate(masm, argc, ExternalReference(IC_Utility(kCallIC_Miss))); } - +/* void CallIC::GeneratePreMonomorphic(MacroAssembler* masm, int argc) { Generate(masm, argc, ExternalReference(IC_Utility(kCallIC_Miss))); } +*/ - void CallIC::GenerateMiss(MacroAssembler* masm, int argc) { Generate(masm, argc, ExternalReference(IC_Utility(kCallIC_Miss))); } Index: src/x64/stub-cache-x64.cc =================================================================== --- src/x64/stub-cache-x64.cc (revision 2477) +++ src/x64/stub-cache-x64.cc (working copy) @@ -44,24 +44,24 @@ JSFunction* c, String* d, StubCompiler::CheckType e) { - UNIMPLEMENTED(); - return NULL; + // TODO(X64): Implement a real stub. + return Failure::InternalError(); } Object* CallStubCompiler::CompileCallField(Object* a, JSObject* b, int c, String* d) { - UNIMPLEMENTED(); - return NULL; + // TODO(X64): Implement a real stub. + return Failure::InternalError(); } Object* CallStubCompiler::CompileCallInterceptor(Object* a, JSObject* b, String* c) { - UNIMPLEMENTED(); - return NULL; + // TODO(X64): Implement a real stub. + return Failure::InternalError(); } @@ -71,8 +71,8 @@ JSGlobalPropertyCell* cell, JSFunction* function, String* name) { - UNIMPLEMENTED(); - return NULL; + // TODO(X64): Implement a real stub. + return Failure::InternalError(); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
