Author: [email protected]
Date: Wed Jul 15 23:55:39 2009
New Revision: 2478

Modified:
    branches/bleeding_edge/tools/gyp/v8.gyp

Log:
Patch by Mark Mentovai: Disable dead code stripping for mksnapshot on
Mac OS to work around code generation issue; see the issue details on
http://code.google.com/p/v8/issues/detail?id=404.

Original review: http://codereview.chromium.org/155591


Modified: branches/bleeding_edge/tools/gyp/v8.gyp
==============================================================================
--- branches/bleeding_edge/tools/gyp/v8.gyp     (original)
+++ branches/bleeding_edge/tools/gyp/v8.gyp     Wed Jul 15 23:55:39 2009
@@ -506,6 +506,20 @@
      {
        'target_name': 'mksnapshot',
        'type': 'executable',
+      'configurations': {
+        'Release': {
+          'conditions': [
+            ['OS=="mac"', {
+              'xcode_settings': {
+                # Dead code stripping is normally enabled for release mode,
+                # but it causes mksnapshot to crash in some situations.
+                # http://code.google.com/p/v8/issues/detail?id=404
+                'DEAD_CODE_STRIPPING': 'NO',
+              },
+            }],
+          ],
+        },
+      },
        'dependencies': [
          'v8_nosnapshot',
        ],

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to