//Lars

http://codereview.chromium.org/155350/diff/1004/27
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/155350/diff/1004/27#newcode115
Line 115: __ and_(t1, r3, Operand(t1, ROR, (kShift * i) % kBitsPerInt));
On 2009/07/16 12:41:43, Kasper Lund wrote:
> Maybe this needs to be guarded with something like i > 0, becuase I'm
not sure
> ROR is legal with a count of zero on ARM.

Fixed, good catch.

http://codereview.chromium.org/155350/diff/1004/21
File src/objects.cc (right):

http://codereview.chromium.org/155350/diff/1004/21#newcode6549
Line 6549: if (nof + (nof>>1) <= capacity) return this;
On 2009/07/16 12:41:43, Kasper Lund wrote:
> Why did you remove the whitespace here?

Too old to remember. I've added the missing spaces.

http://codereview.chromium.org/155350

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to