I think we should. Let me take care of that. I probably want to add that to the patch for branches/1.2.
On Fri, Jul 17, 2009 at 10:10 AM, <[email protected]> wrote: > LGTM. > > > http://codereview.chromium.org/155679/diff/1/6 > File src/ia32/register-allocator-ia32-inl.h (right): > > http://codereview.chromium.org/155679/diff/1/6#newcode68 > Line 68: const Register registers[] = { eax, ebx, ecx, edx, edi }; > This static also occurs above in RegisterAllocator::ToNumber, and > analogously in the ARM and x64 files. I wonder if we should change > those too? > > http://codereview.chromium.org/155679 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
