LGTM.
http://codereview.chromium.org/155635/diff/2001/15 File src/api.cc (right): http://codereview.chromium.org/155635/diff/2001/15#newcode2458 Line 2458: // Fast case, aligned native pointer Terminate comment with . http://codereview.chromium.org/155635/diff/2001/15#newcode2464 Line 2464: // Play safe even if it's something unexpected Terminate comment with . http://codereview.chromium.org/155635/diff/2001/15#newcode2469 Line 2469: // Unaligned native pointer Terminate comment with . http://codereview.chromium.org/155635/diff/2001/15#newcode2490 Line 2490: if (reinterpret_cast<i::Object*>(value)->IsSmi()) { Introduce a local variable to avoid reinterpret_cast'ing the value to i::Object* twice. http://codereview.chromium.org/155635/diff/2001/15#newcode2494 Line 2494: // Currently internal fields used by DOM wrappers which used -> are used which got GCed by mark phases -> which only get GCed by the mark-sweep collector http://codereview.chromium.org/155635 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
