LGTM!

http://codereview.chromium.org/155771/diff/1/3
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/155771/diff/1/3#newcode943
Line 943: // These instructions may be affected an 0x66, 0xF2, or 0xF3
prefix,
Terminate with period instead of comma.

affected -> affected by?

http://codereview.chromium.org/155771/diff/1/3#newcode947
Line 947: byte *current = data + 2;
byte * -> byte*

http://codereview.chromium.org/155771/diff/1/2
File test/cctest/cctest.status (right):

http://codereview.chromium.org/155771/diff/1/2#newcode122
Line 122: test-api/RegExpInterruption: SKIP
Why not just mark as TIMEOUT?

http://codereview.chromium.org/155771

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to