Bill, Can you please add a regression test?
Thanks, -Ivan On Wednesday, July 22, 2009, <[email protected]> wrote: > > Reviewers: Kevin Millikin, > > Message: > A 4-character review for you. > > Description: > Correct sense of test for generic keyed load with a symbol as key. > > Please review this at http://codereview.chromium.org/155922 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/ia32/ic-ia32.cc > > > Index: src/ia32/ic-ia32.cc > =================================================================== > --- src/ia32/ic-ia32.cc (revision 2522) > +++ src/ia32/ic-ia32.cc (working copy) > @@ -282,7 +282,7 @@ > __ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset)); > __ movzx_b(ebx, FieldOperand(ebx, Map::kInstanceTypeOffset)); > __ test(ebx, Immediate(kIsSymbolMask)); > - __ j(not_zero, &slow, not_taken); > + __ j(zero, &slow, not_taken); > // Probe the dictionary leaving result in ecx. > GenerateDictionaryLoad(masm, &slow, ebx, ecx, edx, eax); > GenerateCheckNonObjectOrLoaded(masm, &slow, ecx, edx); > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
