Revision: 2525 Author: [email protected] Date: Thu Jul 23 05:51:49 2009 Log: Change a few style issues (dead code, unitialized members) flagged by Coverity Prevent. All are benign.
Review URL: http://codereview.chromium.org/159264 http://code.google.com/p/v8/source/detail?r=2525 Modified: /branches/bleeding_edge/src/bootstrapper.cc /branches/bleeding_edge/src/rewriter.cc /branches/bleeding_edge/src/spaces.cc ======================================= --- /branches/bleeding_edge/src/bootstrapper.cc Wed Jul 15 05:30:28 2009 +++ /branches/bleeding_edge/src/bootstrapper.cc Thu Jul 23 05:51:49 2009 @@ -47,14 +47,10 @@ // generate an index for each native JS file. class SourceCodeCache BASE_EMBEDDED { public: - explicit SourceCodeCache(Script::Type type): type_(type) { } + explicit SourceCodeCache(Script::Type type): type_(type), cache_(NULL) { } void Initialize(bool create_heap_objects) { - if (create_heap_objects) { - cache_ = Heap::empty_fixed_array(); - } else { - cache_ = NULL; - } + cache_ = create_heap_objects ? Heap::empty_fixed_array() : NULL; } void Iterate(ObjectVisitor* v) { ======================================= --- /branches/bleeding_edge/src/rewriter.cc Tue Jun 16 04:47:00 2009 +++ /branches/bleeding_edge/src/rewriter.cc Thu Jul 23 05:51:49 2009 @@ -38,8 +38,9 @@ class AstOptimizer: public AstVisitor { public: - explicit AstOptimizer() {} - explicit AstOptimizer(Handle<String> enclosing_name) { + explicit AstOptimizer() : has_function_literal_(false) {} + explicit AstOptimizer(Handle<String> enclosing_name) + : has_function_literal_(false) { func_name_inferrer_.PushEnclosingName(enclosing_name); } ======================================= --- /branches/bleeding_edge/src/spaces.cc Tue Jul 14 15:38:06 2009 +++ /branches/bleeding_edge/src/spaces.cc Thu Jul 23 05:51:49 2009 @@ -133,8 +133,6 @@ #endif stop_page_ = space->last_page_; break; - default: - UNREACHABLE(); } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
