http://codereview.chromium.org/160041/diff/1001/1002 File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/160041/diff/1001/1002#newcode473 Line 473: __ ldr(reg, FieldMemOperand(ip, AccessorInfo::kDataOffset)); On 2009/07/23 21:12:58, antonm wrote: > why not push data immediately if data() belongs to new space? Maybe because on ARM loading an Object constant is also a load instruction from the constant pool? No difference and you save on code/constant pool space. http://codereview.chromium.org/160041/diff/1001/1004 File src/stub-cache.cc (right): http://codereview.chromium.org/160041/diff/1001/1004#newcode750 Line 750: LOG(ApiNamedPropertyAccess("load", *recv, *name)); Do you really intend to log for every single property access with a callback? I know that code was there before, but maybe it is time to evaluate if we ever are looking at this log output? http://codereview.chromium.org/160041/diff/1001/1004#newcode754 Line 754: HandleScope scope; On 2009/07/23 21:12:58, antonm wrote: > maybe move scope just before entering fun? for example, to reduce its scope > (sorry) and make it easier for maintainer to understand that scope is only > needed for fun? And where would the result handle on the next line be allocated? http://codereview.chromium.org/160041 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
