http://codereview.chromium.org/159263/diff/1/7 File src/handles.cc (right):
http://codereview.chromium.org/159263/diff/1/7#newcode348 Line 348: if (has_exception) return Handle<Object>(Failure::Exception()); On 2009/07/23 14:21:45, Mads Ager wrote: > We never return failures in handles because we should be able to assume that if > we have a handle there is a valid thing in it. This should hit an assertion. > The handle-based operations are guarded (or should be) at the call site. If an > empty handle is returned from one of them, it is because of an exception. Done. http://codereview.chromium.org/159263/diff/1/8 File src/objects.cc (right): http://codereview.chromium.org/159263/diff/1/8#newcode2525 Line 2525: ? Smi::cast(JSArray::cast(this)->length())->value() On 2009/07/23 14:21:45, Mads Ager wrote: > Is this what the Google code style says? I actually thought it was correctly > 4-space indented before. Done. http://codereview.chromium.org/159263 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
