LGTM.
http://codereview.chromium.org/159397/diff/1/2 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/159397/diff/1/2#newcode1350 Line 1350: reinterpret_cast<byte*>( Use "Address" instead of "byte*". http://codereview.chromium.org/159397/diff/1/2#newcode1357 Line 1357: NameOfAddress(*reinterpret_cast<byte**>(data+1))); Use "Address*" instead of "byte**" (Much more readable!) http://codereview.chromium.org/159397/diff/1/2#newcode1367 Line 1367: switch (operand_size()) { Would it be possible to combine the two cases that only differ on the format string? http://codereview.chromium.org/159397/diff/1/2#newcode1371 Line 1371: *reinterpret_cast<int32_t*>(data + 1)))); ditto. http://codereview.chromium.org/159397/diff/1/2#newcode1377 Line 1377: NameOfAddress(*reinterpret_cast<byte**>(data+1))); And ditto. http://codereview.chromium.org/159397 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
