I have commented all the pushes. I think commenting the pop is overkill. On Mon, Jul 27, 2009 at 12:32 PM, <[email protected]> wrote:
> LGTM. > > > http://codereview.chromium.org/159402/diff/1/2 > File src/ia32/ic-ia32.cc (right): > > http://codereview.chromium.org/159402/diff/1/2#newcode752 > Line 752: __ pop(ebx); > Perhaps add comment to this line as well? > // return address > > > http://codereview.chromium.org/159402 > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
