LGTM.
http://codereview.chromium.org/160160/diff/1/3 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/160160/diff/1/3#newcode499 Line 499: __ DecrementCounter(&Counters::named_store_global_inline, 1); It seems weird to increment this counter on all paths and then decrement it here. Why not increment it on only the fast path? http://codereview.chromium.org/160160/diff/1/2 File test/mjsunit/mjsunit.status (right): http://codereview.chromium.org/160160/diff/1/2#newcode101 Line 101: new: PASS, CRASH || FAIL if ($mode == debug) I'm surprised by the test expectation change (the commit message doesn't mention it). Do you really expect this test to pass in release mode now, or do you mean that the old CRASH || FAIL behavior is still OK? http://codereview.chromium.org/160160 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
