Revision: 2544
Author: [email protected]
Date: Mon Jul 27 11:51:46 2009
Log: X64: Fix buggy expression in disassembler. Fixes Issue 408:
http://code.google.com/p/v8/issues/detail?id=408
Review URL: http://codereview.chromium.org/160174
http://code.google.com/p/v8/source/detail?r=2544
Modified:
/branches/bleeding_edge/src/x64/disasm-x64.cc
=======================================
--- /branches/bleeding_edge/src/x64/disasm-x64.cc Mon Jul 27 03:39:46 2009
+++ /branches/bleeding_edge/src/x64/disasm-x64.cc Mon Jul 27 11:51:46 2009
@@ -1350,7 +1350,7 @@
const char* memory_location = NameOfAddress(
reinterpret_cast<byte*>(
*reinterpret_cast<int32_t*>(data + 1)));
- if (*data & 0x2 == 0x2) { // Opcode 0xA3
+ if (*data == 0xA3) { // Opcode 0xA3
AppendToBuffer("movzxlq rax,(%s)", memory_location);
} else { // Opcode 0xA1
AppendToBuffer("movzxlq (%s),rax", memory_location);
@@ -1362,7 +1362,7 @@
// New x64 instruction mov rax,(imm_64).
const char* memory_location = NameOfAddress(
*reinterpret_cast<byte**>(data + 1));
- if (*data & 0x2 == 0x2) { // Opcode 0xA3
+ if (*data == 0xA3) { // Opcode 0xA3
AppendToBuffer("movq rax,(%s)", memory_location);
} else { // Opcode 0xA1
AppendToBuffer("movq (%s),rax", memory_location);
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
