LGTM.

http://codereview.chromium.org/155682/diff/2027/2031
File src/objects.cc (right):

http://codereview.chromium.org/155682/diff/2027/2031#newcode6038
Line 6038: HandleScope scope;
Consider moving handle stuff one level up (as it was before). The move
doesn't slow down the case we care about and makes the code considerably
simpler.

http://codereview.chromium.org/155682/diff/2027/2031#newcode6067
Line 6067: Object* result = holder->GetPropertyPostInterceptor(receiver,
name, attributes);
Line too long.

http://codereview.chromium.org/155682/diff/2027/2029
File src/stub-cache.cc (right):

http://codereview.chromium.org/155682/diff/2027/2029#newcode807
Line 807: {
Document the block, e.g. "Use the interceptor getter".

http://codereview.chromium.org/155682

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to