LGTM, but:
http://codereview.chromium.org/159587/diff/1001/11 File src/heap.cc (right): http://codereview.chromium.org/159587/diff/1001/11#newcode2106 Line 2106: ASSERT(map->instance_type() != JS_FUNCTION_TYPE); Maybe avoid using this for allocating global objects and extend the assert to check that we don't? http://codereview.chromium.org/159587/diff/1001/11#newcode2165 Line 2165: StringDictionary::Allocate(map->NumberOfDescribedProperties() * 2 + 4); I think you're right: A bigger size would be good here. Maybe you should try to count the number of resizes we do when running the bootstrapping code (maybe try to use Date too to get that lazy loaded). http://codereview.chromium.org/159587/diff/1001/11#newcode2171 Line 2171: Object* result = AllocateJSObjectFromMap(map, TENURED, dictionary); Have you considered not using AlloacteJSObjectFromMap, but just call Allocate and InitializeJSObjectFromMap directly from here? That way, you wouldn't have to pass the initial_properties all the time... http://codereview.chromium.org/159587 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
