LGTM

http://codereview.chromium.org/160393/diff/8/1004
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/160393/diff/8/1004#newcode262
Line 262: {"cmovbe", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false},
This one and the next should be "cmova" and "cmovna", to follow the
condition codes from conditional_code_suffix.

http://codereview.chromium.org/160393/diff/8/1004#newcode267
Line 267: {"cmovnp", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false},
And parity is represented as "pe" and "po" (even/odd).

http://codereview.chromium.org/160393

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to