Except for the addition of the new files, this LGTM.
http://codereview.chromium.org/159695/diff/1/6 File src/SConscript (right): http://codereview.chromium.org/159695/diff/1/6#newcode39 Line 39: 'bootstrapper.cc', 'builtins.cc', 'checks.cc', 'cfg.cc', There are a ton of other places you need to add new files. http://codereview.chromium.org/159695/diff/1/2 File src/cfg.h (right): http://codereview.chromium.org/159695/diff/1/2#newcode111 Line 111: virtual void Unmark() = 0; I think you should add a few comments about the use of the marking/unmarking. http://codereview.chromium.org/159695/diff/1/2#newcode276 Line 276: ExpressionBuilder() : value_(new Constant(Handle<Object>::null())) {} Could this null constant be shared? http://codereview.chromium.org/159695 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
