Reviewers: plesner, Description: Enable C++ missing virtual destructor warning.
-Wnon-virtual-dtor is part of -Wall on gcc 4.0.3, but not on 4.2.4. Enable it specifically. Please review this at http://codereview.chromium.org/160450 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct Index: SConstruct =================================================================== --- SConstruct (revision 2595) +++ SConstruct (working copy) @@ -218,8 +218,11 @@ 'gcc': { 'all': { 'CXXFLAGS': [], #['-fvisibility=hidden'], - 'WARNINGFLAGS': ['-Wall', '-Werror', '-W', - '-Wno-unused-parameter'] + 'WARNINGFLAGS': ['-Wall', + '-Werror', + '-W', + '-Wno-unused-parameter', + '-Wnon-virtual-dtor'] }, 'os:win32': { 'WARNINGFLAGS': ['-pedantic', '-Wno-long-long'] --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
