LGTM
http://codereview.chromium.org/160452/diff/1/5 File src/string-stream.cc (right): http://codereview.chromium.org/160452/diff/1/5#newcode172 Line 172: EmbeddedVector<char, 28> formatted; 28 seems like overkill. If printed as hex, even with a "0x" prefix, it shouldn't take more than 18 bytes. http://codereview.chromium.org/160452/diff/1/4 File src/x64/ic-x64.cc (right): http://codereview.chromium.org/160452/diff/1/4#newcode428 Line 428: // used as an index in a memory operand. Where is it checked that it isn't negative? (On the other hand, a zero extended negative 32-bit number would be too large for use as an index). http://codereview.chromium.org/160452/diff/1/4#newcode429 Line 429: __ movl(rbx, rbx); // Clear the high bits of rbx. A thought: Would xchgl(rax, rax) also clear the top half? (being nop, it shouldn't). http://codereview.chromium.org/160452 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
