LGTM with a comment. William, you sent it to a false Mikhail ;)
http://codereview.chromium.org/151004/diff/2001/3001 File src/platform-macos.cc (right): http://codereview.chromium.org/151004/diff/2001/3001#newcode530 Line 530: sample.pc = state.__rip; I think you also need to duplicate __DARWIN_UNIX03 switch here (or use a #define which either adds a double underscore prefix or none.) I remember that when you compile Chromium, !__DARWIN_UNIX03 branch is used. http://codereview.chromium.org/151004 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
