http://codereview.chromium.org/160453/diff/1/7 File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/160453/diff/1/7#newcode56 Line 56: static inline bool is_int32(uint64_t x) { I'm not sure we shouldn't find a better way to bite someone in the behind for holding signed data in unsigned variables, and using them without casting. But let's rename for now. The function isn't used yet, it was just added for symmetry. http://codereview.chromium.org/160453/diff/1/9 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/160453/diff/1/9#newcode161 Line 161: j(zero, &done); Done. http://codereview.chromium.org/160453/diff/1/9#newcode170 Line 170: } else { Done. http://codereview.chromium.org/160453 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
