LGTM. On Mon, Aug 3, 2009 at 12:46 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Removed some comments which did not make any sense. > > Please review this at http://codereview.chromium.org/159783 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/ast.h > M src/variables.h > > > Index: src/variables.h > =================================================================== > --- src/variables.h (revision 2604) > +++ src/variables.h (working copy) > @@ -162,9 +162,7 @@ > // be the global scope). scope() is NULL in that case. Currently the > // scope is only used to follow the context chain length. > Scope* scope() const { return scope_; } > - // If this assertion fails it means that some code has tried to > - // treat the special this variable as an ordinary variable with > - // the name "this". > + > Handle<String> name() const { return name_; } > Mode mode() const { return mode_; } > bool is_accessed_from_inner_scope() const { > Index: src/ast.h > =================================================================== > --- src/ast.h (revision 2604) > +++ src/ast.h (working copy) > @@ -821,9 +821,6 @@ > return (variable == NULL) ? false : variable->is_arguments(); > } > > - // If this assertion fails it means that some code has tried to > - // treat the special "this" variable as an ordinary variable with > - // the name "this". > Handle<String> name() const { return name_; } > Variable* var() const { return var_; } > UseCount* var_uses() { return &var_uses_; } > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
