Revision: 22042
Author: [email protected]
Date: Thu Jun 26 15:12:04 2014 UTC
Log: Remove unused Debug::AfterCompileFlags flags.
[email protected]
Review URL: https://codereview.chromium.org/353823004
Patch from Alexey Kozyatinskiy <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22042
Modified:
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/src/debug.cc
/branches/bleeding_edge/src/debug.h
/branches/bleeding_edge/src/liveedit.cc
=======================================
--- /branches/bleeding_edge/src/compiler.cc Thu Jun 26 06:32:51 2014 UTC
+++ /branches/bleeding_edge/src/compiler.cc Thu Jun 26 15:12:04 2014 UTC
@@ -860,7 +860,7 @@
live_edit_tracker.RecordFunctionInfo(result, lit, info->zone());
}
- isolate->debug()->OnAfterCompile(script, Debug::NO_AFTER_COMPILE_FLAGS);
+ isolate->debug()->OnAfterCompile(script);
return result;
}
=======================================
--- /branches/bleeding_edge/src/debug.cc Wed Jun 25 09:13:09 2014 UTC
+++ /branches/bleeding_edge/src/debug.cc Thu Jun 26 15:12:04 2014 UTC
@@ -2647,8 +2647,7 @@
// Handle debugger actions when a new script is compiled.
-void Debug::OnAfterCompile(Handle<Script> script,
- AfterCompileFlags after_compile_flags) {
+void Debug::OnAfterCompile(Handle<Script> script) {
// Add the newly compiled script to the script cache.
if (script_cache_ != NULL) script_cache_->Add(script);
@@ -2656,9 +2655,6 @@
if (in_debug_scope() || ignore_events()) return;
HandleScope scope(isolate_);
- // Store whether in debugger before entering debugger.
- bool was_in_scope = in_debug_scope();
-
DebugScope debug_scope(this);
if (debug_scope.failed()) return;
@@ -2690,8 +2686,6 @@
argv).is_null()) {
return;
}
- // Bail out based on state or if there is no listener for this event
- if (was_in_scope && (after_compile_flags & SEND_WHEN_DEBUGGING) == 0)
return;
// Create the compile state object.
Handle<Object> event_data;
=======================================
--- /branches/bleeding_edge/src/debug.h Mon Jun 23 07:10:25 2014 UTC
+++ /branches/bleeding_edge/src/debug.h Thu Jun 26 15:12:04 2014 UTC
@@ -364,17 +364,11 @@
// DebugInfo.
class Debug {
public:
- enum AfterCompileFlags {
- NO_AFTER_COMPILE_FLAGS,
- SEND_WHEN_DEBUGGING
- };
-
// Debug event triggers.
void OnDebugBreak(Handle<Object> break_points_hit, bool auto_continue);
void OnException(Handle<Object> exception, bool uncaught);
void OnBeforeCompile(Handle<Script> script);
- void OnAfterCompile(Handle<Script> script,
- AfterCompileFlags after_compile_flags);
+ void OnAfterCompile(Handle<Script> script);
void OnScriptCollected(int id);
// API facing.
=======================================
--- /branches/bleeding_edge/src/liveedit.cc Wed Jun 11 13:40:18 2014 UTC
+++ /branches/bleeding_edge/src/liveedit.cc Thu Jun 26 15:12:04 2014 UTC
@@ -1477,7 +1477,7 @@
Handle<Script> old_script = CreateScriptCopy(original_script);
old_script->set_name(String::cast(*old_script_name));
old_script_object = old_script;
- isolate->debug()->OnAfterCompile(old_script,
Debug::SEND_WHEN_DEBUGGING);
+ isolate->debug()->OnAfterCompile(old_script);
} else {
old_script_object = isolate->factory()->null_value();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
