Reviewers: dcarney,
Message:
PTAL
Description:
Don't leak the global object in the Function constructor.
BUG=
Please review this at https://codereview.chromium.org/359713005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -1 lines):
M src/runtime.cc
A test/mjsunit/regress/regress-function-constructor-receiver.js
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
831f76dd778d77e88af030d9cebd32710bc93c26..703e20fc189748cc1823eda7f4d5632299ddc5cb
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -8248,7 +8248,7 @@ static Object* Runtime_NewObjectHelper(Isolate*
isolate,
// instead of a new JSFunction object. This way, errors are
// reported the same way whether or not 'Function' is called
// using 'new'.
- return isolate->context()->global_object();
+ return isolate->context()->global_proxy();
}
}
Index: test/mjsunit/regress/regress-function-constructor-receiver.js
diff --git a/test/mjsunit/regress/regress-function-constructor-receiver.js
b/test/mjsunit/regress/regress-function-constructor-receiver.js
new file mode 100644
index
0000000000000000000000000000000000000000..f345435ade0d72063307bf49267e9f11513ce42d
--- /dev/null
+++ b/test/mjsunit/regress/regress-function-constructor-receiver.js
@@ -0,0 +1,17 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Return the raw CallSites array.
+Error.prepareStackTrace = function (a,b) { return b; };
+
+var threw = false;
+try {
+ new Function({toString:0,valueOf:0});
+} catch (e) {
+ threw = true;
+ // Ensure that the receiver during "new Function" is the global proxy.
+ assertEquals(this, e.stack[0].getThis());
+}
+
+assertTrue(threw);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
