LGTM with comment
https://codereview.chromium.org/350913004/diff/1/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/350913004/diff/1/tools/testrunner/local/execution.py#newcode144
tools/testrunner/local/execution.py:144: self._RunPerfSafe(lambda:
self.perfdata.UpdatePerfData(test))
One more suggestion: move this up one line and into the "else" block (so
it's executed iff "self.succeeded += 1" is executed too). No need to
taint collected performance statistics with the time it took for the
test to fail in a bad run.
https://codereview.chromium.org/350913004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
