Revision: 22058
Author:   [email protected]
Date:     Fri Jun 27 10:37:42 2014 UTC
Log:      Unbreak "os" stuff in shared d8 builds.

Note that "os" still has no properties on Windows, but at least it's there.

BUG=v8:3407
LOG=y
[email protected]

Review URL: https://codereview.chromium.org/356843005
http://code.google.com/p/v8/source/detail?r=22058

Modified:
 /branches/bleeding_edge/src/d8-posix.cc
 /branches/bleeding_edge/src/d8-windows.cc
 /branches/bleeding_edge/src/d8.cc
 /branches/bleeding_edge/src/d8.gyp

=======================================
--- /branches/bleeding_edge/src/d8-posix.cc     Fri Jun 20 08:40:11 2014 UTC
+++ /branches/bleeding_edge/src/d8-posix.cc     Fri Jun 27 10:37:42 2014 UTC
@@ -2,22 +2,18 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-
 #include <errno.h>
 #include <fcntl.h>
-#include <signal.h>
 #include <stdlib.h>
+#include <string.h>
+#include <sys/select.h>
 #include <sys/stat.h>
 #include <sys/time.h>
 #include <sys/types.h>
 #include <sys/wait.h>
-#include <time.h>
 #include <unistd.h>

-
 #include "src/d8.h"
-#include "src/d8-debug.h"
-#include "src/debug.h"


 namespace v8 {
=======================================
--- /branches/bleeding_edge/src/d8-windows.cc   Fri Jun 20 08:40:11 2014 UTC
+++ /branches/bleeding_edge/src/d8-windows.cc   Fri Jun 27 10:37:42 2014 UTC
@@ -2,11 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-
-#include "src/api.h"
 #include "src/d8.h"
-#include "src/d8-debug.h"
-#include "src/debug.h"


 namespace v8 {
=======================================
--- /branches/bleeding_edge/src/d8.cc   Mon Jun 23 13:52:17 2014 UTC
+++ /branches/bleeding_edge/src/d8.cc   Fri Jun 27 10:37:42 2014 UTC
@@ -872,11 +872,9 @@
                        performance_template);
 #endif  // !V8_SHARED

-#if !defined(V8_SHARED) && !defined(_WIN32) && !defined(_WIN64)
   Handle<ObjectTemplate> os_templ = ObjectTemplate::New(isolate);
   AddOSMethods(isolate, os_templ);
   global_template->Set(String::NewFromUtf8(isolate, "os"), os_templ);
-#endif  // !V8_SHARED && !_WIN32 && !_WIN64

   return global_template;
 }
=======================================
--- /branches/bleeding_edge/src/d8.gyp  Tue Jun  3 08:12:43 2014 UTC
+++ /branches/bleeding_edge/src/d8.gyp  Fri Jun 27 10:37:42 2014 UTC
@@ -57,6 +57,14 @@
           'libraries': [ '-lreadline', ],
           'sources': [ 'd8-readline.cc' ],
         }],
+        ['(OS=="linux" or OS=="mac" or OS=="freebsd" or OS=="netbsd" \
+           or OS=="openbsd" or OS=="solaris" or OS=="android" \
+           or OS=="qnx")', {
+             'sources': [ 'd8-posix.cc', ]
+           }],
+        [ 'OS=="win"', {
+          'sources': [ 'd8-windows.cc', ]
+        }],
         [ 'component!="shared_library"', {
'sources': [ 'd8-debug.cc', '<(SHARED_INTERMEDIATE_DIR)/d8-js.cc', ],
           'conditions': [
@@ -69,14 +77,6 @@
                 'd8_js2c',
               ],
             }],
-            ['(OS=="linux" or OS=="mac" or OS=="freebsd" or OS=="netbsd" \
-               or OS=="openbsd" or OS=="solaris" or OS=="android" \
-               or OS=="qnx")', {
-              'sources': [ 'd8-posix.cc', ]
-            }],
-            [ 'OS=="win"', {
-              'sources': [ 'd8-windows.cc', ]
-            }],
           ],
         }],
         ['v8_enable_vtunejit==1', {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to