Reviewers: Benedikt Meurer,
Description:
Remove remaining dependencies on allocation.h from a few platform files
I could move parts of allocation to base/ instead, but I see little to
no value in the allocation base classes, soo..
BUG=none
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/351683009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -6 lines):
M src/platform-posix.cc
M src/platform-win32.cc
M src/platform/time.h
Index: src/platform-posix.cc
diff --git a/src/platform-posix.cc b/src/platform-posix.cc
index
928edb86a5dc1c397f1c2bc79747dd7a71ef44a7..bc9d8e2fd419296037a9d7ee809e5225011ef6e4
100644
--- a/src/platform-posix.cc
+++ b/src/platform-posix.cc
@@ -492,7 +492,7 @@ void OS::StrNCpy(char* dest, int length, const char*
src, size_t n) {
// POSIX thread support.
//
-class Thread::PlatformData : public Malloced {
+class Thread::PlatformData {
public:
PlatformData() : thread_(kNoThread) {}
pthread_t thread_; // Thread handle for pthread.
Index: src/platform-win32.cc
diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index
1897b75be68cf1e88da3bf07f257501ac00bb376..f89c107aad2dec2d424343689ce595f048463900
100644
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -1335,7 +1335,7 @@ static unsigned int __stdcall ThreadEntry(void* arg) {
}
-class Thread::PlatformData : public Malloced {
+class Thread::PlatformData {
public:
explicit PlatformData(HANDLE thread) : thread_(thread) {}
HANDLE thread_;
Index: src/platform/time.h
diff --git a/src/platform/time.h b/src/platform/time.h
index
0cd234c3dd5fa21f94840a5f0251d6c137cfe374..d21e85d15a5fcdea271c48448be1a35c09438c78
100644
--- a/src/platform/time.h
+++ b/src/platform/time.h
@@ -8,7 +8,7 @@
#include <time.h>
#include <limits>
-#include "src/allocation.h"
+#include "src/base/macros.h"
// Forward declarations.
extern "C" {
@@ -30,7 +30,7 @@ class TimeTicks;
// This class represents a duration of time, internally represented in
// microseonds.
-class TimeDelta V8_FINAL BASE_EMBEDDED {
+class TimeDelta V8_FINAL {
public:
TimeDelta() : delta_(0) {}
@@ -158,7 +158,7 @@ class TimeDelta V8_FINAL BASE_EMBEDDED {
// This class represents an absolute point in time, internally represented
as
// microseconds (s/1,000,000) since 00:00:00 UTC, January 1, 1970.
-class Time V8_FINAL BASE_EMBEDDED {
+class Time V8_FINAL {
public:
static const int64_t kMillisecondsPerSecond = 1000;
static const int64_t kMicrosecondsPerMillisecond = 1000;
@@ -295,7 +295,7 @@ inline Time operator+(const TimeDelta& delta, const
Time& time) {
// Time::Now() may actually decrease or jump). But note that TimeTicks may
// "stand still", for example if the computer suspended.
-class TimeTicks V8_FINAL BASE_EMBEDDED {
+class TimeTicks V8_FINAL {
public:
TimeTicks() : ticks_(0) {}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
