Reviewers: rossberg,
Message:
Committed patchset #1 manually as r22066 (tree was closed).
Description:
Port the ic part
BUG=
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=22066
Please review this at https://codereview.chromium.org/354173002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -25 lines):
M src/arm/ic-arm.cc
M src/arm64/ic-arm64.cc
M src/mips/ic-mips.cc
M src/x64/ic-x64.cc
M src/x87/ic-x87.cc
Index: src/arm/ic-arm.cc
diff --git a/src/arm/ic-arm.cc b/src/arm/ic-arm.cc
index
d1cd0884f7f5a80c9eadb7ac4a655b5e4cc87ac0..24c6fa51441bb1fe291abf1e591a4ad0634639bc
100644
--- a/src/arm/ic-arm.cc
+++ b/src/arm/ic-arm.cc
@@ -873,7 +873,7 @@ void
KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(r2, r1, r0);
__ mov(r0, Operand(Smi::FromInt(strict_mode))); // Strict mode.
- __ Push(r1, r0);
+ __ Push(r0);
__ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
@@ -1213,12 +1213,11 @@ void
StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(r1, r2, r0);
- __ mov(r1, Operand(Smi::FromInt(NONE))); // PropertyAttributes
__ mov(r0, Operand(Smi::FromInt(strict_mode)));
- __ Push(r1, r0);
+ __ Push(r0);
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
Index: src/arm64/ic-arm64.cc
diff --git a/src/arm64/ic-arm64.cc b/src/arm64/ic-arm64.cc
index
f1de3fa790fe1a92d653b562b95fc8ddfc97c1f5..8340cf1ebd16a2ee6ba1ade539467e8e6e410e20
100644
--- a/src/arm64/ic-arm64.cc
+++ b/src/arm64/ic-arm64.cc
@@ -911,12 +911,11 @@ void
KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
// Push receiver, key and value for runtime call.
__ Push(x2, x1, x0);
- // Push PropertyAttributes(NONE) and strict_mode for runtime call.
- STATIC_ASSERT(NONE == 0);
+ // Push strict_mode for runtime call.
__ Mov(x10, Smi::FromInt(strict_mode));
- __ Push(xzr, x10);
+ __ Push(x10);
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
@@ -1258,12 +1257,11 @@ void
StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(x1, x2, x0);
- __ Mov(x11, Smi::FromInt(NONE)); // PropertyAttributes
__ Mov(x10, Smi::FromInt(strict_mode));
- __ Push(x11, x10);
+ __ Push(x10);
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
Index: src/mips/ic-mips.cc
diff --git a/src/mips/ic-mips.cc b/src/mips/ic-mips.cc
index
24db0ce0f0deaae2ba600d62719d50ed079deba2..b14cd7b8fdbb2e9595ceec8e541af91522096cce
100644
--- a/src/mips/ic-mips.cc
+++ b/src/mips/ic-mips.cc
@@ -795,11 +795,10 @@ void
KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
// Push receiver, key and value for runtime call.
__ Push(a2, a1, a0);
- __ li(a1, Operand(Smi::FromInt(NONE))); // PropertyAttributes.
__ li(a0, Operand(Smi::FromInt(strict_mode))); // Strict mode.
- __ Push(a1, a0);
+ __ Push(a0);
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
@@ -1233,12 +1232,11 @@ void
StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(a1, a2, a0);
- __ li(a1, Operand(Smi::FromInt(NONE))); // PropertyAttributes.
__ li(a0, Operand(Smi::FromInt(strict_mode)));
- __ Push(a1, a0);
+ __ Push(a0);
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
Index: src/x64/ic-x64.cc
diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc
index
a03eba17f8663652d2825c046445f55daea4be71..e08366504a29fda0bca5896422a42b7314c156da
100644
--- a/src/x64/ic-x64.cc
+++ b/src/x64/ic-x64.cc
@@ -1148,12 +1148,11 @@ void
StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(rdx);
__ Push(rcx);
__ Push(rax);
- __ Push(Smi::FromInt(NONE)); // PropertyAttributes
__ Push(Smi::FromInt(strict_mode));
__ PushReturnAddressFrom(rbx);
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
@@ -1170,12 +1169,11 @@ void
KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ Push(rdx); // receiver
__ Push(rcx); // key
__ Push(rax); // value
- __ Push(Smi::FromInt(NONE)); // PropertyAttributes
__ Push(Smi::FromInt(strict_mode)); // Strict mode.
__ PushReturnAddressFrom(rbx);
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
Index: src/x87/ic-x87.cc
diff --git a/src/x87/ic-x87.cc b/src/x87/ic-x87.cc
index
a8c8654b97cf7fce0965ef2d843901e8e6c902d8..828e3f97354e745d6122c72a268f368cf3a226dd
100644
--- a/src/x87/ic-x87.cc
+++ b/src/x87/ic-x87.cc
@@ -1132,12 +1132,11 @@ void
StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ push(edx);
__ push(ecx);
__ push(eax);
- __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes
__ push(Immediate(Smi::FromInt(strict_mode)));
__ push(ebx); // return address
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
@@ -1154,12 +1153,11 @@ void
KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
__ push(edx);
__ push(ecx);
__ push(eax);
- __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes
__ push(Immediate(Smi::FromInt(strict_mode))); // Strict mode.
__ push(ebx); // return address
// Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
