LGTM.
http://codereview.chromium.org/162001/diff/1/2 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/162001/diff/1/2#newcode59 Line 59: masm->and_(object, ~Page::kPageAlignmentMask); This whole function is probably clearer if we introduce a symbolic alias for 'object'. Something like 'base', 'start', 'page_start'? http://codereview.chromium.org/162001/diff/1/2#newcode70 Line 70: // Adjust 'addr' to be relative to the start of the extra remembered set On 2009/08/05 10:17:50, William Hesse wrote: > This comment is no longer right. I would comment > "Store the length of the fixed array in object." > and > "Let object be the starting address of the extra remembered set, minus > kRSetOffset and minus an offset of the remembered set bits which are stored in > the first part of the remembered set, but still counted in addr. > The two offsets add up to kRSetEndOffset. I would ditch the whole comment and use symbolic aliases for the register names to make it more clear. http://codereview.chromium.org/162001/diff/1/2#newcode80 Line 80: // object + kObjectStartOffset + FixedArray::kHeaderSize + 8 * scratch Surely not 8? http://codereview.chromium.org/162001 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
