Revision: 22080
Author: [email protected]
Date: Mon Jun 30 08:39:04 2014 UTC
Log: Use simple keyed store again in ArrayPush_JS_Builtin
This reverts the change of array.js in r20839 and recovers 38%
performance regression of DOM-Search case in Browsermark2.0. There is
no performance impact on JavaScript benchmarks (Octane, Kraken and
SunSpider).
BUG=
[email protected]
Review URL: https://codereview.chromium.org/353953002
Patch from Weiliang Lin <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22080
Modified:
/branches/bleeding_edge/src/array.js
=======================================
--- /branches/bleeding_edge/src/array.js Fri Jun 27 13:48:37 2014 UTC
+++ /branches/bleeding_edge/src/array.js Mon Jun 30 08:39:04 2014 UTC
@@ -443,9 +443,7 @@
var m = %_ArgumentsLength();
for (var i = 0; i < m; i++) {
- // Use SetProperty rather than a direct keyed store to ensure that the
store
- // site doesn't become poisened with an elements transition
KeyedStoreIC.
- %SetProperty(array, i+n, %_Arguments(i), kStrictMode);
+ array[i+n] = %_Arguments(i);
}
var new_length = n + m;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
