lgtm with some comments
https://codereview.chromium.org/343563009/diff/50001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/343563009/diff/50001/src/isolate.cc#newcode457
src/isolate.cc:457: JSObject::SetProperty(error_object, key,
stack_trace, NONE, STRICT).Assert();
SetProperty can fail if the object isn't extensible. So if I create a
non-extensible object with a configurable stack property, I'll get the
stack getter/setter, but no hidden symbols to contain the value.
https://codereview.chromium.org/343563009/diff/50001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/343563009/diff/50001/src/messages.js#newcode1149
src/messages.js:1149: holder = %GetPrototype(holder);
This runs through the prototype chain twice, and the first is just an
expensive "early bailout". I'd rather add after holder =
%GetPrototype(holder); if (!holder) return UNDEFINED;
https://codereview.chromium.org/343563009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
