Addressed comments and rebased. PTAL again.
https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):
https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc#oldcode1266
src/bootstrapper.cc:1266: JSObject::SetOwnPropertyIgnoreAttributes(
On 2014/06/27 10:51:02, rossberg wrote:
Hm, why can this call just be dropped?
Because NewJSObjectFromMap properly initializes all pre-allocated fields
to undefined, independent of inobject-slack-tracking. The map is marked
to have 1 pre-allocate property field, which is "length".
Added an ASSERT though that it actually contains undefined_value.
https://codereview.chromium.org/352813002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/352813002/diff/1/src/objects.h#newcode2155
src/objects.h:2155: static void InitializeProperty(Handle<JSObject>
object,
On 2014/06/27 10:51:02, rossberg wrote:
As discussed offline, it'd be nicer to call this AddProperty
Done.
https://codereview.chromium.org/352813002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/352813002/diff/1/src/runtime.cc#newcode8132
src/runtime.cc:8132: JSObject::SetOwnPropertyIgnoreAttributes(
Because "length" is already declared on the bound_function_map. This is
actually an InitializeProperty use.
On 2014/06/27 10:51:02, rossberg wrote:
Why can't InitProperty be used here?
https://codereview.chromium.org/352813002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
